[llvm] ccf16c4 - Make test more robust

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 06:48:32 PDT 2020


Author: James Henderson
Date: 2020-04-06T14:47:05+01:00
New Revision: ccf16c4d381d11e20de142cbb540102c8f6e0777

URL: https://github.com/llvm/llvm-project/commit/ccf16c4d381d11e20de142cbb540102c8f6e0777
DIFF: https://github.com/llvm/llvm-project/commit/ccf16c4d381d11e20de142cbb540102c8f6e0777.diff

LOG: Make test more robust

llvm-readobj prints the file path as part of the output, so
--implicit-check-not patterns can accidentally match it. This patch
makes the test more robust by preventing failures if "foo" is in
somebody's path.

Reviewed by: grimar

Differential Revision: https://reviews.llvm.org/D77546

Added: 
    

Modified: 
    llvm/test/tools/llvm-objcopy/ELF/shared-strtab-shstrtab.s

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-objcopy/ELF/shared-strtab-shstrtab.s b/llvm/test/tools/llvm-objcopy/ELF/shared-strtab-shstrtab.s
index 11d000b81b8c..b692d7691772 100644
--- a/llvm/test/tools/llvm-objcopy/ELF/shared-strtab-shstrtab.s
+++ b/llvm/test/tools/llvm-objcopy/ELF/shared-strtab-shstrtab.s
@@ -60,7 +60,7 @@
 ## Case 5: removing a symbol.
 # RUN: llvm-objcopy %t.o %t.remove-symbol -N foo
 # RUN: llvm-readobj --section-headers --symbols %t.remove-symbol \
-# RUN:   | FileCheck %s --check-prefix=SYMBOL-REMOVE --implicit-check-not=.shstrtab --implicit-check-not=foo
+# RUN:   | FileCheck %s --check-prefix=SYMBOL-REMOVE --implicit-check-not=.shstrtab --implicit-check-not="Name: foo"
 
 # SYMBOL-REMOVE: Sections [
 # SYMBOL-REMOVE:   Name: .foo (


        


More information about the llvm-commits mailing list