[PATCH] D77496: Make paths in generated llvm-lit relative as well.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 06:27:44 PDT 2020


thakis marked an inline comment as done.
thakis added a comment.

Thanks!



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1430
+  # clang warning checks that passed case matches on-disk cache. So it's
+  # important that this restores the on-disk case of the prefix.
+  "# Allow generated file to be relocatable.\n"
----------------
hans wrote:
> Would it be possible to not lower-case paths in the first place?
Yes, I'd like to try to do that next. There's a bit of history here (`git log -Snormcase llvm/utils/lit`) so maybe it's not super easy. OTOH the original workaround was for a fairly old MSVC, so maybe it's better now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77496/new/

https://reviews.llvm.org/D77496





More information about the llvm-commits mailing list