[PATCH] D61727: [llvm-objcopy] Add additional testing for various cases

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 06:27:43 PDT 2020


jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: llvm/trunk/test/tools/llvm-objcopy/ELF/shared-strtab-shstrtab.s:63
+# RUN: llvm-readobj --section-headers --symbols %t.remove-symbol \
+# RUN:   | FileCheck %s --check-prefix=SYMBOL-REMOVE --implicit-check-not=.shstrtab --implicit-check-not=foo
+
----------------
thakis wrote:
> This makes the test fail if "foo" is a substring of the path of your build dir. Could you make this more robust against accidentally matching the directory name?
See D77546.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61727/new/

https://reviews.llvm.org/D61727





More information about the llvm-commits mailing list