[PATCH] D77525: [mlir][AsmPrinter] Change value numbering for local scope to be the next isolated operation.

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula accepted this revision.
bondhugula added inline comments.


================
Comment at: mlir/include/mlir/IR/Operation.h:608
 inline raw_ostream &operator<<(raw_ostream &os, Operation &op) {
-  op.print(os);
+  op.print(os, OpPrintingFlags().useLocalScope());
   return os;
----------------
Did this race condition exist all along (since pass threading) or was it introduced lately? It looks like when pass threading is on, the printing has to always be "isolated from above" op local?


================
Comment at: mlir/lib/IR/AsmPrinter.cpp:2347
+    // isolated from above.
+    if (flags.shouldUseLocalScope() && printedOp->isKnownIsolatedFromAbove())
+      break;
----------------
Nit: The flags.shouldUseLocalScope() check can be hoisted out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77525/new/

https://reviews.llvm.org/D77525