[PATCH] D72828: [DWARF5] Added support for emission of debug_macro section.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-v5.ll:5
+; RUN: %llc_dwarf -dwarf-version=5 -O0 -filetype=obj < %s \
+;   | llvm-dwarfdump -v - | FileCheck %s
+
----------------
The test fails because this line lacks the `RUN:` prefix.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-v5.ll:27-41
+; Function Attrs: noinline nounwind optnone uwtable
+define dso_local i32 @main() #0 !dbg !18 {
+  %1 = alloca i32, align 4
+  %2 = alloca i32, align 4
+  call void @llvm.dbg.declare(metadata i32* %1, metadata !22, metadata !DIExpression()), !dbg !23
+  store i32 3, i32* %1, align 4, !dbg !23
+  call void @llvm.dbg.declare(metadata i32* %2, metadata !24, metadata !DIExpression()), !dbg !25
----------------
The function `@main()` and its dependencies are not required for the test. Please, shrink the test so that it includes only that is necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72828/new/

https://reviews.llvm.org/D72828