[PATCH] D77383: [FileCheck] Allow parenthesized expressions

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Thanks for this. I think this is a good step in the right direction for FileCheck's numeric expression support. You should probably add something to the FileCheck documentation about operator precedence and also using parentheses.



================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:674
+  expectDiagnosticError("missing ')' at end of nested expression",
+                        Tester.parseSubst("((1+2)+3").takeError());
 }
----------------
Do you think it might make sense for a test case for more closing parentheses than opening ones? E.g. ")" or "())" or maybe even "())("?

Perhaps also something like "(1)(2)" and "2(X)" too with no operation between the operands?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77383/new/

https://reviews.llvm.org/D77383