[PATCH] D77528: [MLIR] Add support to use aligned_alloc to lower AllocOp from std to llvm
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 6 01:36:22 PDT 2020
mehdi_amini added inline comments.
================
Comment at: mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp:50
+ llvm::cl::init(false), llvm::cl::cat(clOptionsCategory));
+
// Extract an LLVM IR type from the LLVM IR dialect type.
----------------
Please don't introduce any new global command line option and thread them through the APIs.
We're looking to eliminate every global initializers under mlir/lib/... : https://bugs.llvm.org/show_bug.cgi?id=45437
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77528/new/
https://reviews.llvm.org/D77528
More information about the llvm-commits
mailing list