[PATCH] D77515: [mlir] Remove need for static global ctors from mlir-translate

Sun Apr 5 14:57:57 PDT 2020

jroelofs marked an inline comment as done and an inline comment as not done.
jroelofs added inline comments.

================
Comment at: mlir/test/EDSC/CMakeLists.txt:24-30
-whole_archive_link(mlir-edsc-builder-api-test
-  MLIRAffine
-  MLIRLinalgOps
-  MLIRLoopOps
-  MLIRStandardOps
-  MLIRVector
-  MLIRTransforms
----------------
jroelofs wrote:
> stephenneuendorffer wrote:
> > Please verify these changes with BUILD_SHARED_LIBS=on.  It should have been the case that the whole_archive_link an link_libraries were mutually exclusive, so I'd expect that all of these need to go in a target_link_libraries instead.
> > BUILD_SHARED_LIBS=ON
> 
> Currently building that config again. That that fell over is what led me down this rabbit hole in the first place :)
> 
> > I'd expect that all of these need to go in a target_link_libraries instead.
> 
> Unless I misunderstood, they're there already.
> BUILD_SHARED_LIBS=ON

Good call. This broke a bunch of test runners. Investigating.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77515/new/

https://reviews.llvm.org/D77515