[PATCH] D76149: [AssumeBundles] Use assume bundles in isKnownNonZero

Tyker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 5 08:32:10 PDT 2020


Tyker added inline comments.


================
Comment at: llvm/lib/Analysis/AssumeBundleQueries.cpp:149
+      IntrinsicInst *II = cast_or_null<IntrinsicInst>(Elem.Assume);
+      if (!II || Elem.Index == AssumptionCache::ExprResultIdx)
+        continue;
----------------
fhahn wrote:
> Can the cache contain elements that are not assumes? I think ideally it would only contain entries with valid assume calls.
the assumption cache cannot hold valid pointers to non-assume instruction.
but it can hold nullptr if an assume was in cache and gets deleted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76149/new/

https://reviews.llvm.org/D76149





More information about the llvm-commits mailing list