[PATCH] D76788: [LVI] Cleanup/unify cache access
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 5 05:51:40 PDT 2020
fhahn added inline comments.
================
Comment at: lib/Analysis/LazyValueInfo.cpp:212
- bool hasCachedValueInfo(Value *V, BasicBlock *BB) const {
- if (isOverdefined(V, BB))
+ bool getCachedValueInfo(ValueLatticeElement &BBLV, Value *V,
+ BasicBlock *BB) const {
----------------
Would it make sense to return Optional<ValuelLatticeElement> instead? IMO that would make things a bit more explicit (and personally I think it's easier to follow than using 'out' parameters)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76788/new/
https://reviews.llvm.org/D76788
More information about the llvm-commits
mailing list