[PATCH] D77486: [MLIR][NFC] fix name operand -> op

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 5 04:15:29 PDT 2020


bondhugula marked 2 inline comments as done.
bondhugula added inline comments.


================
Comment at: mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp:183
         // to revisit them.
         for (auto result : op->getResults())
+          for (auto *userOp : result.getUsers())
----------------
rriddle wrote:
> Can you change this to just `op->getUsers()`? It is cleaner and more efficient.
Yes, but we should do that in another patch - this is meant to be a rename only. There are other instances (two in this file) and about five more in other files that use such a 2-d iteration that could all be replaced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77486/new/

https://reviews.llvm.org/D77486





More information about the llvm-commits mailing list