[PATCH] D77467: [VPlan] Introduce new VPWidenCallRecipe (NFC).

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 5 02:39:43 PDT 2020


Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7072
   // operations, inductions and Phi nodes.
   if ((Recipe = tryToWidenMemory(Instr, Range, Plan)) ||
       (Recipe = tryToOptimizeInduction(Instr, Range)) ||
----------------
add here

```
      (Recipe = tryToWidenCall(Instr, Range)) ||
```

promoting VPWidenCallRecipe to join the "specific widening recipes", keeping tryToWiden() called below as kitchen-sink? It's somewhat confusing to have tryToWiden() call tryToWidenCall(). Similar to the promotion of inlined "tryToWidenGEP" in D69067.

Also augmenting above "with memory operations, [calls,] inductions and Phi nodes" comment.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:617
     VPWidenSC,
+    VPWidenCallSC,
   };
----------------
Lexical order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77467/new/

https://reviews.llvm.org/D77467





More information about the llvm-commits mailing list