[PATCH] D77488: [MLIR] Proposal for file-line numbers in tablegen errors.

[River Riddle via Phabricator via llvm-commits]

rriddle requested changes to this revision.
rriddle added a comment.
This revision now requires changes to proceed.

Thanks!



================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:1051
 public:
   FormatLexer(llvm::SourceMgr &mgr);
 
----------------
Can you populate the location in the constructor so that we can use it for all errors?


================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:1095
+                                    const Twine &note) {
+  llvm::SrcMgr.PrintMessage(op.getLoc()[0],
+                            llvm::SourceMgr::DK_Note,
----------------
nit: Can you move this to after the note below, and add a slightly more descriptive message?

"see the operation defining the assembly format" or something better


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77488/new/

https://reviews.llvm.org/D77488