[PATCH] D77487: [MLIR] Introduce applyOpPatternsAndFold for op local rewrites
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 4 22:55:02 PDT 2020
rriddle requested changes to this revision.
rriddle added inline comments.
This revision now requires changes to proceed.
================
Comment at: mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp:251
+ // notified of any necessary changes, so there is nothing else to do here.
+ changed |= matcher.matchAndRewrite(op, *this);
+ } while (changed && ++i < maxIterations);
----------------
This is wrong, you don't handle when the op is erased by a pattern. This really feels like should be its own driver, it doesn't really share anything.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77487/new/
https://reviews.llvm.org/D77487
More information about the llvm-commits
mailing list