[PATCH] D77486: [MLIR][NFC] fix name operand -> op

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 4 22:55:01 PDT 2020


stephenneuendorffer requested changes to this revision.
stephenneuendorffer added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp:184
         for (auto result : op->getResults())
-          for (auto *operand : result.getUsers())
-            addToWorklist(operand);
+          for (auto *op : result.getUsers())
+            addToWorklist(op);
----------------
This seems like a bad idea to me, since you're shadowing another outer op.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77486/new/

https://reviews.llvm.org/D77486





More information about the llvm-commits mailing list