[PATCH] D75280: [PowerPC][Future] Add initial support for PC Relative addressing for global values

Anil Mahmud via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 4 19:42:26 PDT 2020


anil9 added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:2555
+                   ConstPoolNode->getTargetFlags() == PPCII::MO_PCREL_FLAG;
+  GlobalAddressSDNode *GSDN = dyn_cast<GlobalAddressSDNode>(N.getNode());
+  bool Global = GSDN && GSDN->getTargetFlags() == PPCII::MO_PCREL_FLAG;
----------------
The naming convention is a bit inconsistent :

GSDN / ConstPoolNode , this inconsistency is carried over this patch too. 

https://reviews.llvm.org/D75931

JumpTableSDNode *JT = dyn_cast<JumpTableSDNode>(N.getNode()); 



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75280/new/

https://reviews.llvm.org/D75280





More information about the llvm-commits mailing list