[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

[Craig Topper via Phabricator via llvm-commits]

craig.topper marked 2 inline comments as done.
craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/ImmutableGraph.h:329
+    size_type VI = 0, EI = 0;
+    for (; VI < static_cast<size_type>(AdjList.size()); ++VI) {
+      VertexArray[VI].Value = std::move(AdjList[VI].first);
----------------
Can this be changed to VI < VertexSize?


================
Comment at: llvm/lib/Target/X86/ImmutableGraph.h:369
+        continue;
+      size_type NewNumEdges = std::count_if(
+          NI->edges_begin(), NI->edges_end(),
----------------
I think I'll change this to llvm::count_if.  Also there was previously a conditional here that made sure the distance between edges was >0, but it didn't seem necessary. Please let me know if there's a reason I should put that back


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75936/new/

https://reviews.llvm.org/D75936