[PATCH] D77449: [MLIR] Cleanup mlir-tblgen error messages for custom assembly formats.

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer marked an inline comment as done.
stephenneuendorffer added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:1383
+                       "', is not buildable and a buildable type cannot " +
+                       "be inferred from other types.  Suggest adding a " +
+                       "type constraint to the operation or adding a " +
----------------
rriddle wrote:
> If we are going to have suggestions, they should likely be notes instead of lumped together with the error message.
This is in Tablegen, which doesn't have the normal reporting infrastructure.  Are you suggesting changing that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77449/new/

https://reviews.llvm.org/D77449