[PATCH] D76952: Add mention of advantages of `arc` in the Phabricator doc.
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 3 20:35:08 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1ce0bc39eebe: Add mention of advantages of `arc` in the Phabricator doc. (authored by mehdi_amini).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76952/new/
https://reviews.llvm.org/D76952
Files:
llvm/docs/Phabricator.rst
Index: llvm/docs/Phabricator.rst
===================================================================
--- llvm/docs/Phabricator.rst
+++ llvm/docs/Phabricator.rst
@@ -48,7 +48,11 @@
The tool to create and review patches in Phabricator is called
*Differential*.
-Note that you can upload patches created through git.
+Note that you can upload patches created through git, but using `arc` on the
+command line (see previous section) is prefered: it adds more metadata to
+Phabricator which are useful for the pre-merge testing system and for
+propagating attribution on commits when someone else has to push it for you.
+
To make reviews easier, please always include **as much context as
possible** with your diff! Don't worry, Phabricator
will automatically send a diff with a smaller context in the review
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76952.254998.patch
Type: text/x-patch
Size: 812 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200404/ef63a3bc/attachment.bin>
More information about the llvm-commits
mailing list