[llvm] 1ce0bc3 - Add mention of advantages of `arc` in the Phabricator doc.
Mehdi Amini via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 3 20:22:40 PDT 2020
Author: Mehdi Amini
Date: 2020-04-04T03:22:29Z
New Revision: 1ce0bc39eebe95a350174eb0ed4e2508e7cb6ed8
URL: https://github.com/llvm/llvm-project/commit/1ce0bc39eebe95a350174eb0ed4e2508e7cb6ed8
DIFF: https://github.com/llvm/llvm-project/commit/1ce0bc39eebe95a350174eb0ed4e2508e7cb6ed8.diff
LOG: Add mention of advantages of `arc` in the Phabricator doc.
Differential Revision: https://reviews.llvm.org/D76952
Added:
Modified:
llvm/docs/Phabricator.rst
Removed:
################################################################################
diff --git a/llvm/docs/Phabricator.rst b/llvm/docs/Phabricator.rst
index f6b7fa50d79e..0a4b1e74c305 100644
--- a/llvm/docs/Phabricator.rst
+++ b/llvm/docs/Phabricator.rst
@@ -48,7 +48,11 @@ Requesting a review via the web interface
The tool to create and review patches in Phabricator is called
*Differential*.
-Note that you can upload patches created through git.
+Note that you can upload patches created through git, but using `arc` on the
+command line (see previous section) is prefered: it adds more metadata to
+Phabricator which are useful for the pre-merge testing system and for
+propagating attribution on commits when someone else has to push it for you.
+
To make reviews easier, please always include **as much context as
possible** with your
diff ! Don't worry, Phabricator
will automatically send a
diff with a smaller context in the review
More information about the llvm-commits
mailing list