[PATCH] D77425: [NFC] Make Type::isVectorTy call isa<VectorType>

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 14:39:05 PDT 2020


ctetreau added a comment.

In D77425#1960531 <https://reviews.llvm.org/D77425#1960531>, @efriedma wrote:

> This will fail to compile if someone includes Type.h without including DerivedTypes.h.


Right you are. I guess I didn't notice because in practice everybody includes DerivedType. I changed it to work like the old vector getters.

I actually wanted to get rid of this function too, but there are literally thousands of usages of it...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77425/new/

https://reviews.llvm.org/D77425





More information about the llvm-commits mailing list