[PATCH] D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 12:58:05 PDT 2020


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

I'm totally in favor of verbose commit descriptions :D
You can probably just remove the first paragraph.



================
Comment at: llvm/lib/CodeGen/WasmEHPrepare.cpp:351
+                                 bool NeedLSDA, unsigned Index) {
+  static bool init = false;
+  if (!init) {
----------------
In principle, passes should be thread-safe if they have separate LLVMContext objects. Can we hang `init` off the pass object instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77423/new/

https://reviews.llvm.org/D77423





More information about the llvm-commits mailing list