[PATCH] D77402: [AssumeBundles] adapt Assumption cache to assume bundles

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 12:26:31 PDT 2020


jdoerfert added a reviewer: hfinkel.
jdoerfert added a comment.

How does this work with multiple occurrences of a value in an assume?

---

> change assumption cache to store an assume along with an index to the operand bundle containg the knoledge.

Two typos in the commit message



================
Comment at: llvm/lib/Analysis/AssumptionCache.cpp:85
+  }
+
   Value *Cond = CI->getArgOperand(0), *A, *B;
----------------
Clang format the above please.


================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1708
+        CS.getInstruction(),
+        IFI.GetAssumptionCache ? &(*IFI.GetAssumptionCache)(*Caller) : nullptr);
 
----------------
Can you make this a variable, hard to read and interpret this way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77402/new/

https://reviews.llvm.org/D77402





More information about the llvm-commits mailing list