[PATCH] D77413: Support: Add specializations for reverseBits to use builtin
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 3 11:20:24 PDT 2020
aaron.ballman added a comment.
In D77413#1960156 <https://reviews.llvm.org/D77413#1960156>, @arsenm wrote:
> In D77413#1960124 <https://reviews.llvm.org/D77413#1960124>, @aaron.ballman wrote:
>
> > This LGTM, but I'm not certain how we could add test coverage for the change. Maybe this is sufficiently obvious to be okay without it, though.
>
>
> It's already covered by unit tests
That's true -- I was thinking in terms of checking use of the fallback vs the builtin, but I suppose we don't care which gets used, just that the results are correct. LGTM fully now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77413/new/
https://reviews.llvm.org/D77413
More information about the llvm-commits
mailing list