[PATCH] D76624: [MSan] Add instrumentation for SystemZ
Ulrich Weigand via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 3 11:20:23 PDT 2020
uweigand added a comment.
The Z ABI implementation now looks correct to me, except for one corner case: an LLVM-level argument type of f128 is passed via implicit reference. Now, in most cases this is already handled at the clang level, i.e. when you have a "long double" at C source level, you'll already see a pointer type in the LLVM IR instead. However, there are still a few cases where there is a f128 at the LLVM IR level, e.g. as arguments to some compiler builtin / libgcc routines. Those are only transformed to implicit reference in the LLVM back-end, so I believe for completeness this case should also be handled here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76624/new/
https://reviews.llvm.org/D76624
More information about the llvm-commits
mailing list