[PATCH] D77363: Use git-clang-format as Arcanist linter

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

I missed a bit of the discussion in the previous review, but why would we want/need to use the git-clang-format wrapper? We aren't exposing any of the git-related features and we just have a fixed command-line anyway.

@mehdi_amini how did you install clang format? It seems like our CMake doesn't actually install a `clang-format-diff` executable, only a `clang-format-diff.py` executable, but it gets packaged on e.g. Debian/Ubuntu as `clang-format-diff`. I didn't think to check what LLVM does vs. what my distribution does when reviewing, but since it differs we may have to look for several different possible installations?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77363/new/

https://reviews.llvm.org/D77363