[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D77227#1959936 <https://reviews.llvm.org/D77227#1959936>, @probinson wrote:

> I'm inclined to change my mind and say let's NOT allow spaces before the colon.  There are actual CHECKs in the wild that want to check strings that start with a colon, and the rules about CHECK directives are already a bit much.  People are used to indenting directives to make things line up, I don't see spaces-before-colon as really being a huge win for readability.


I think I agree.  Permitting those spaces would mean we couldn't diagnose this:

  // CHECK: :15:1: error: expected identifier or '('
  // CHECK  :13:14: note: expanded from macro 'FOOL'
  // CHECK: :12:15: note: expanded from macro 'DROOL'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227