[PATCH] D77330: Consider increasing the default ARM32 page size to 64k.
James Y Knight via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 3 09:41:06 PDT 2020
jyknight added a comment.
In D77330#1959071 <https://reviews.llvm.org/D77330#1959071>, @srhines wrote:
> We (Android Google folks) have an internal thread going on about what implications this might have, but I can say that I am concerned about making this kind of change for ARM Android targets. Even though we manually set a 4KB max page size in our platform builds for 32-bit, we also have to consider the needs of NDK developers (i.e. those folks making native applications/games/etc.). Some of their build configurations might behave very differently with this change, so my current thinking is that 64KB should **not** be the default for ARM Android targets.
Can you say more about your concern? I was actually thinking the exact opposite -- that the special-case in the Driver to use 4K pages on Android AArch64 could very likely be removed, now that using the default 64k max-page-size will no longer cause the binary size to increase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77330/new/
https://reviews.llvm.org/D77330
More information about the llvm-commits
mailing list