[PATCH] D77283: scudo: Add support for diagnosing memory errors when memory tagging is enabled.

[Stephen Hines via Phabricator via llvm-commits]

srhines added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:35
 
+#if SCUDO_ANDROID && __ANDROID_API__ == 10000
+// This function is not part of the NDK so it does not appear in any public
----------------
cryptoad wrote:
> I am not sure how `__ANDROID_API__` works, should it be `>=`? (same for all the others)
No, since this isn't part of the NDK, this should be using the `== 10000` check, which is a special value that indicates that you are building for the platform (i.e. not the NDK).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77283/new/

https://reviews.llvm.org/D77283