[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Grepping for `\bCHECK[A-Z0-9-]*\s+:` finds nothing in clang/test or llvm/test.  Is "gotcha 2" a real thing we should worry about?  If there are any cases like that, we'd catch them under the checks for "gotcha 1".
I'm inclined to change my mind and say let's NOT allow spaces before the colon.  There are actual CHECKs in the wild that want to check strings that start with a colon, and the rules about CHECK directives are already a bit much.  People are used to indenting directives to make things line up, I don't see spaces-before-colon as really being a huge win for readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227