[llvm] 4824b5e - [Alignment][NFC] Remove documentation and FIXME for deprecated functions
Guillaume Chatelet via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 3 07:16:49 PDT 2020
Author: Guillaume Chatelet
Date: 2020-04-03T14:16:37Z
New Revision: 4824b5ecce2648907725b1bf0c95612f40ef2c1f
URL: https://github.com/llvm/llvm-project/commit/4824b5ecce2648907725b1bf0c95612f40ef2c1f
DIFF: https://github.com/llvm/llvm-project/commit/4824b5ecce2648907725b1bf0c95612f40ef2c1f.diff
LOG: [Alignment][NFC] Remove documentation and FIXME for deprecated functions
Added:
Modified:
llvm/include/llvm/CodeGen/MachineFrameInfo.h
llvm/include/llvm/CodeGen/MachineFunction.h
llvm/include/llvm/CodeGen/MachineMemOperand.h
llvm/include/llvm/IR/GlobalObject.h
llvm/include/llvm/IR/IRBuilder.h
llvm/include/llvm/IR/InstrTypes.h
Removed:
################################################################################
diff --git a/llvm/include/llvm/CodeGen/MachineFrameInfo.h b/llvm/include/llvm/CodeGen/MachineFrameInfo.h
index f0fb7655881b..c5e57e6da549 100644
--- a/llvm/include/llvm/CodeGen/MachineFrameInfo.h
+++ b/llvm/include/llvm/CodeGen/MachineFrameInfo.h
@@ -460,8 +460,6 @@ class MachineFrameInfo {
Objects[ObjectIdx+NumFixedObjects].Size = Size;
}
- /// Return the alignment of the specified stack object.
- /// FIXME: Remove this function once transition to Align is over.
LLVM_ATTRIBUTE_DEPRECATED(inline unsigned getObjectAlignment(int ObjectIdx)
const,
"Use getObjectAlign instead") {
@@ -486,8 +484,6 @@ class MachineFrameInfo {
ensureMaxAlignment(Alignment);
}
- /// setObjectAlignment - Change the alignment of the specified stack object.
- /// FIXME: Remove this function once transition to Align is over.
LLVM_ATTRIBUTE_DEPRECATED(inline void setObjectAlignment(int ObjectIdx,
unsigned Align),
"Use the version that takes Align instead") {
@@ -589,7 +585,7 @@ class MachineFrameInfo {
/// Make sure the function is at least Align bytes aligned.
void ensureMaxAlignment(Align Alignment);
- /// FIXME: Remove this once transition to Align is over.
+
LLVM_ATTRIBUTE_DEPRECATED(inline void ensureMaxAlignment(unsigned Align),
"Use the version that uses Align instead") {
ensureMaxAlignment(assumeAligned(Align));
diff --git a/llvm/include/llvm/CodeGen/MachineFunction.h b/llvm/include/llvm/CodeGen/MachineFunction.h
index a1626fe5529a..b4a7e99b5521 100644
--- a/llvm/include/llvm/CodeGen/MachineFunction.h
+++ b/llvm/include/llvm/CodeGen/MachineFunction.h
@@ -818,7 +818,6 @@ class MachineFunction {
AtomicOrdering Ordering = AtomicOrdering::NotAtomic,
AtomicOrdering FailureOrdering = AtomicOrdering::NotAtomic);
- /// FIXME: Remove once transition to Align is over.
LLVM_ATTRIBUTE_DEPRECATED(
inline MachineMemOperand *getMachineMemOperand(
MachinePointerInfo PtrInfo, MachineMemOperand::Flags f, uint64_t s,
diff --git a/llvm/include/llvm/CodeGen/MachineMemOperand.h b/llvm/include/llvm/CodeGen/MachineMemOperand.h
index 650d50bd45d6..4f0c4aeb94f4 100644
--- a/llvm/include/llvm/CodeGen/MachineMemOperand.h
+++ b/llvm/include/llvm/CodeGen/MachineMemOperand.h
@@ -222,9 +222,6 @@ class MachineMemOperand {
/// Return the size in bits of the memory reference.
uint64_t getSizeInBits() const { return Size * 8; }
- /// Return the minimum known alignment in bytes of the actual memory
- /// reference.
- /// FIXME: Remove once transition to Align is over.
LLVM_ATTRIBUTE_DEPRECATED(uint64_t getAlignment() const,
"Use getAlign instead");
@@ -232,9 +229,6 @@ class MachineMemOperand {
/// reference.
Align getAlign() const;
- /// Return the minimum known alignment in bytes of the base address, without
- /// the offset.
- /// FIXME: Remove once transition to Align is over.
LLVM_ATTRIBUTE_DEPRECATED(uint64_t getBaseAlignment() const,
"Use getBaseAlign instead") {
return BaseAlign.value();
diff --git a/llvm/include/llvm/IR/GlobalObject.h b/llvm/include/llvm/IR/GlobalObject.h
index faa9e296da72..cd0b2dccdcac 100644
--- a/llvm/include/llvm/IR/GlobalObject.h
+++ b/llvm/include/llvm/IR/GlobalObject.h
@@ -82,7 +82,6 @@ class GlobalObject : public GlobalValue {
return decodeMaybeAlign(AlignmentData);
}
- /// FIXME: Remove this setter once the migration to MaybeAlign is over.
LLVM_ATTRIBUTE_DEPRECATED(void setAlignment(unsigned Align),
"Please use `void setAlignment(MaybeAlign Align)`");
void setAlignment(MaybeAlign Align);
diff --git a/llvm/include/llvm/IR/IRBuilder.h b/llvm/include/llvm/IR/IRBuilder.h
index d4449e196000..92c282aec629 100644
--- a/llvm/include/llvm/IR/IRBuilder.h
+++ b/llvm/include/llvm/IR/IRBuilder.h
@@ -520,8 +520,6 @@ class IRBuilderBase {
/// If the pointer isn't an i8*, it will be converted. If a TBAA tag is
/// specified, it will be added to the instruction. Likewise with alias.scope
/// and noalias tags.
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes Align instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(
CallInst *CreateElementUnorderedAtomicMemSet(
Value *Ptr, Value *Val, uint64_t Size, unsigned Alignment,
@@ -544,8 +542,6 @@ class IRBuilderBase {
TBAATag, ScopeTag, NoAliasTag);
}
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes Align instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(
CallInst *CreateElementUnorderedAtomicMemSet(
Value *Ptr, Value *Val, Value *Size, unsigned Alignment,
@@ -569,8 +565,6 @@ class IRBuilderBase {
/// If the pointers aren't i8*, they will be converted. If a TBAA tag is
/// specified, it will be added to the instruction. Likewise with alias.scope
/// and noalias tags.
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes MaybeAlign instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(
CallInst *CreateMemCpy(Value *Dst, unsigned DstAlign, Value *Src,
unsigned SrcAlign, uint64_t Size,
@@ -595,8 +589,6 @@ class IRBuilderBase {
NoAliasTag);
}
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes MaybeAlign instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(
CallInst *CreateMemCpy(Value *Dst, unsigned DstAlign, Value *Src,
unsigned SrcAlign, Value *Size,
@@ -629,8 +621,6 @@ class IRBuilderBase {
MDNode *TBAAStructTag = nullptr, MDNode *ScopeTag = nullptr,
MDNode *NoAliasTag = nullptr);
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes Align instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(CallInst *CreateElementUnorderedAtomicMemCpy(
Value *Dst, unsigned DstAlign, Value *Src,
unsigned SrcAlign, uint64_t Size,
@@ -644,8 +634,6 @@ class IRBuilderBase {
TBAATag, TBAAStructTag, ScopeTag, NoAliasTag);
}
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes Align instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(CallInst *CreateElementUnorderedAtomicMemCpy(
Value *Dst, unsigned DstAlign, Value *Src,
unsigned SrcAlign, Value *Size,
@@ -659,14 +647,6 @@ class IRBuilderBase {
TBAAStructTag, ScopeTag, NoAliasTag);
}
- /// Create and insert a memmove between the specified
- /// pointers.
- ///
- /// If the pointers aren't i8*, they will be converted. If a TBAA tag is
- /// specified, it will be added to the instruction. Likewise with alias.scope
- /// and noalias tags.
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes MaybeAlign instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(
CallInst *CreateMemMove(
Value *Dst, unsigned DstAlign, Value *Src, unsigned SrcAlign,
@@ -685,8 +665,7 @@ class IRBuilderBase {
return CreateMemMove(Dst, DstAlign, Src, SrcAlign, getInt64(Size),
isVolatile, TBAATag, ScopeTag, NoAliasTag);
}
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes MaybeAlign instead of this one.
+
LLVM_ATTRIBUTE_DEPRECATED(
CallInst *CreateMemMove(
Value *Dst, unsigned DstAlign, Value *Src, unsigned SrcAlign,
@@ -717,8 +696,6 @@ class IRBuilderBase {
MDNode *TBAAStructTag = nullptr, MDNode *ScopeTag = nullptr,
MDNode *NoAliasTag = nullptr);
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes Align instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(CallInst *CreateElementUnorderedAtomicMemMove(
Value *Dst, unsigned DstAlign, Value *Src,
unsigned SrcAlign, uint64_t Size,
@@ -732,8 +709,6 @@ class IRBuilderBase {
TBAATag, TBAAStructTag, ScopeTag, NoAliasTag);
}
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes Align instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(CallInst *CreateElementUnorderedAtomicMemMove(
Value *Dst, unsigned DstAlign, Value *Src,
unsigned SrcAlign, Value *Size,
@@ -1747,11 +1722,6 @@ class IRBuilderBase {
return Insert(new StoreInst(Val, Ptr, isVolatile));
}
- /// Provided to resolve 'CreateAlignedLoad(Ptr, Align, "...")'
- /// correctly, instead of converting the string to 'bool' for the isVolatile
- /// parameter.
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes MaybeAlign instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(LoadInst *CreateAlignedLoad(Type *Ty, Value *Ptr,
unsigned Align,
const char *Name),
@@ -1764,8 +1734,7 @@ class IRBuilderBase {
LI->setAlignment(Align);
return LI;
}
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes MaybeAlign instead of this one.
+
LLVM_ATTRIBUTE_DEPRECATED(LoadInst *CreateAlignedLoad(Type *Ty, Value *Ptr,
unsigned Align,
const Twine &Name = ""),
@@ -1778,8 +1747,7 @@ class IRBuilderBase {
LI->setAlignment(Align);
return LI;
}
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes MaybeAlign instead of this one.
+
LLVM_ATTRIBUTE_DEPRECATED(LoadInst *CreateAlignedLoad(Type *Ty, Value *Ptr,
unsigned Align,
bool isVolatile,
@@ -1837,8 +1805,6 @@ class IRBuilderBase {
Align, isVolatile, Name);
}
- /// FIXME: Remove this function once transition to Align is over.
- /// Use the version that takes MaybeAlign instead of this one.
LLVM_ATTRIBUTE_DEPRECATED(
StoreInst *CreateAlignedStore(Value *Val, Value *Ptr, unsigned Align,
bool isVolatile = false),
diff --git a/llvm/include/llvm/IR/InstrTypes.h b/llvm/include/llvm/IR/InstrTypes.h
index c8a00f6971ad..d28b3301fa6a 100644
--- a/llvm/include/llvm/IR/InstrTypes.h
+++ b/llvm/include/llvm/IR/InstrTypes.h
@@ -1588,8 +1588,6 @@ class CallBase : public Instruction {
MaybeAlign getRetAlign() const { return Attrs.getRetAlignment(); }
/// Extract the alignment for a call or parameter (0=unknown).
- /// FIXME: Remove this function once transition to Align is over.
- /// Use getParamAlign() instead.
LLVM_ATTRIBUTE_DEPRECATED(unsigned getParamAlignment(unsigned ArgNo) const,
"Use getParamAlign() instead") {
if (const auto MA = Attrs.getParamAlignment(ArgNo))
More information about the llvm-commits
mailing list