[PATCH] D77386: [Alignment][NFC] Allow to print alignment to raw_ostream

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet created this revision.
gchatelet added a reviewer: courbet.
Herald added subscribers: llvm-commits, atanasyan, jrtc27, hiraditya, sdardis, jholewinski.
Herald added a project: LLVM.
courbet added a comment.

I'd rather have every user forced to think whether they want to use the value or its internal (log) representation, e.g. `.p2align` vs MIR format. If only for debug, then:

  #ifndef NDEBUG
  std::string Align::DebugStr() const {
    return "Align(" + value + ")";
  }
  #endif

WDYT ?


This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77386

Files:
  llvm/include/llvm/CodeGen/MIRYamlMapping.h
  llvm/include/llvm/Support/raw_ostream.h
  llvm/lib/CodeGen/MIRPrinter.cpp
  llvm/lib/CodeGen/MachineFrameInfo.cpp
  llvm/lib/CodeGen/MachineOperand.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/MC/MCFragment.cpp
  llvm/lib/Support/raw_ostream.cpp
  llvm/lib/Target/Mips/MipsRegisterInfo.cpp
  llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
  llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77386.254764.patch
Type: text/x-patch
Size: 8600 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200403/d12e8dce/attachment.bin>