[PATCH] D77381: Fix shape inference in toy tutorial

[Frederik Gossen via Phabricator via llvm-commits]

frgossen created this revision.
Herald added subscribers: llvm-commits, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.
frgossen updated this revision to Diff 254751.
frgossen added a comment.
frgossen updated this revision to Diff 254752.

Fix formatting


frgossen added a comment.

Honestly, learning how to use arc diff.


The implementation of shape inference in the toy tutorial did not conform to the correct algorithmic description. 
The result was only correct because all operations appear to be processed in sequence.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77381

Files:
  mlir/examples/toy/Ch4/mlir/ShapeInferencePass.cpp
  mlir/examples/toy/Ch5/mlir/ShapeInferencePass.cpp
  mlir/examples/toy/Ch6/mlir/ShapeInferencePass.cpp
  mlir/examples/toy/Ch7/mlir/ShapeInferencePass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77381.254752.patch
Type: text/x-patch
Size: 4368 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200403/80571e4f/attachment.bin>