[PATCH] D77247: Merge FloatingPointMode and FPEnv headers

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 04:16:05 PDT 2020


sepavloff added a comment.

I put my patch here: D77379 <https://reviews.llvm.org/D77379>. Taking rounding mode from `IR/FPEnv.h` may look awkward as rounding modes are used in APFloat implementation, which is in Support library. It however does not break anything as it is only header use. Moving content of `IR/FPEnv.h` to Support library is not an option because it contains IR specific declarations and companion source file `FPEnv.cpp` references things from IR library. We also could move rounding mode enumeration into `APFloat.h` but it would put RoundingMode and DenormalMode into different headers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77247/new/

https://reviews.llvm.org/D77247





More information about the llvm-commits mailing list