[PATCH] D77133: [mlir] Add an out-of-tree dialect example

[Marius Brehler via Phabricator via llvm-commits]

marbre added inline comments.


================
Comment at: mlir/examples/standalone/standalone-opt/standalone-opt.cpp:25
+using namespace llvm;
+using namespace mlir;
+
----------------
If it is an out-of-tree example, I would avoid `using namespace`.


================
Comment at: mlir/examples/standalone/standalone-opt/standalone-opt.cpp:58
+  registerAllDialects();
+  registerAllPasses();
+
----------------
One could avoid registering all core dialects and passes here, but it might be more useful to change this in a follow-up.


================
Comment at: mlir/examples/standalone/standalone-opt/standalone-opt.cpp:61
+  registerDialect<standalone::StandaloneDialect>();
+  // TODO: Register standalone passes here.
+
----------------
A standalone pass is out of scope of this example?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77133/new/

https://reviews.llvm.org/D77133