[PATCH] D77299: [InstCombine] convert bitcast-shuffle to vector trunc

Jeroen Dobbelaere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 02:07:30 PDT 2020


jeroen.dobbelaere added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp:1691
+      continue;
+    int64_t LSBIndex = IsBigEndian ? (i + 1) * TruncRatio - 1 : i * TruncRatio;
+    assert(LSBIndex <= std::numeric_limits<int32_t>::max() &&
----------------
unsigned * unsigned = unsigned. Make 'TruncRatio' int64_t (or, use uint64_t, just like in D76983).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77299/new/

https://reviews.llvm.org/D77299





More information about the llvm-commits mailing list