[PATCH] D77292: [Alignment][NFC] Convert MachineIRBuilder::buildDynStackAlloc to Align
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 3 02:07:27 PDT 2020
courbet requested changes to this revision.
courbet added inline comments.
This revision now requires changes to proceed.
================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h:381
/// \return a MachineInstrBuilder for the newly created instruction.
MachineInstrBuilder buildDynStackAlloc(const DstOp &Res, const SrcOp &Size,
+ MaybeAlign Align);
----------------
What about taking an alignment now that we're clarified the meaning of `0` ? There's only one caller now and no alignment does not have any particular meaning compared to 1.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77292/new/
https://reviews.llvm.org/D77292
More information about the llvm-commits
mailing list