[PATCH] D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 01:34:53 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

In D76081#1957186 <https://reviews.llvm.org/D76081#1957186>, @Higuoxing wrote:

> Correct grammatical mistakes. I will try my best to avoid these mistakes next time ...


Don't worry about it (obviously do your best, but don't spend hours agonising about a comment's grammar - it's what I'm here for!).

LGTM. I think landing D77289 <https://reviews.llvm.org/D77289> first might make slightly more sense, but I don't have a strong opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76081/new/

https://reviews.llvm.org/D76081





More information about the llvm-commits mailing list