[PATCH] D77352: [llvm] Fix missing FileCheck directive colons

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 01:34:53 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/spe.ll:46
   ret float %v
-; CHECK-LABEL @test_fmul
 }
----------------
I'm not sure I follow why it's safe to remove the lines from this test?


================
Comment at: llvm/test/CodeGen/PowerPC/umulo-128-legalisation-lowering.ll:154
 ; PPC32-NEXT:    blr
-; PPC32-LABEL muloti_test:
 start:
----------------
Are you sure this line should be removed?


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/irtranslator-callingconv.ll:318
 define i32 * @test_memop_i32(i32 * %p1) {
-;X64    liveins: $rdi
   ; X32-LABEL: name: test_memop_i32
----------------
Are you sure this line should be removed?


================
Comment at: llvm/test/CodeGen/X86/avx-vzeroupper.ll:86
 ; BTVER2-NEXT:    retq
-; DISABLE-VZ       # %bb.0:
   %tmp = load <4 x float>, <4 x float>* @x, align 16
----------------
Any thoughts on why this line is here, and why it is safe to remove (i.e. instead of fixing)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77352/new/

https://reviews.llvm.org/D77352





More information about the llvm-commits mailing list