[PATCH] D77344: [AMDGPU] Propagate AGPR RC from PHI to its PHI operands

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 16:50:20 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFixSGPRCopies.cpp:854
 
+  // Propagate register class back to PHI operands which are PHI themself.
+  while (!PHIOperands.empty()) {
----------------
s/themself/themselves


================
Comment at: llvm/test/CodeGen/AMDGPU/mfma-loop.ll:534
+}
+
 declare <32 x float> @llvm.amdgcn.mfma.f32.32x32x1f32(float, float, <32 x float>, i32, i32, i32)
----------------
Should also have a test where a phi directly refers to itself


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77344/new/

https://reviews.llvm.org/D77344





More information about the llvm-commits mailing list