[PATCH] D76866: Enable new passmanager plugin support for LTO.

[serge via Phabricator via llvm-commits]

serge-sans-paille added a comment.

> Statically linked plugins can't be tested in regression tests because there are none by default

Yeah, if you add

  REQUIRES: plugins, examples

you have the guarantee that the ``Bye`` plugin will be compiled. But by default it's compiled dynamically, and you need to set ``-DLLVM_BYE_LINK_INTO_TOOLS=ON`` to have the static test. Your approach looks good.



================
Comment at: llvm/test/Feature/load_extension.ll:1
+; REQUIRES: x86-registered-target
 ; RUN: opt %s %loadbye -goodbye -wave-goodbye -disable-output 2>&1 | FileCheck %s
----------------
why?


================
Comment at: llvm/test/lit.cfg.py:212
+                                                         config.llvm_shlib_ext)))
+    config.substitutions.append(('%loadnewpmbye',
+                                 '-load-pass-plugin={}/Bye{}'
----------------
typo: ``%loadbyenewpm`` != ``%loadnewpmbye``


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76866/new/

https://reviews.llvm.org/D76866