[PATCH] D77364: [mlir][Linalg] Employ finer-grained control of C interface emission
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 2 21:41:24 PDT 2020
mehdi_amini accepted this revision.
mehdi_amini added inline comments.
This revision is now accepted and ready to land.
================
Comment at: mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp:406
+ ArrayRef<NamedAttribute>{});
+ funcOp.setAttr("llvm.emit_c_interface", UnitAttr::get(op->getContext()));
return fnNameAttr;
----------------
Can you add a comment explaining this?
This is obvious in the context of this diff, but I'm thinking about someone who does not know the detail of this dance and trying to read this code later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77364/new/
https://reviews.llvm.org/D77364
More information about the llvm-commits
mailing list