[PATCH] D77319: [WIP] Remove the getNegatibleCost

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang marked an inline comment as done.
steven.zhang added a comment.

In D77319#1957709 <https://reviews.llvm.org/D77319#1957709>, @efriedma wrote:

> Can you split whatever change affects the PPC tests into a separate patch, if it's not too tricky?


Yes, I am trying to do it, and that is the main reason why this revision is in WIP status.  It seems that we have different combine  order for that case that result in different combination result, though they are semantics the same. I will take a deep look at this.



================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:3534
                                        bool LegalOperations, bool ForCodeSize,
+                                       bool &IsProfitable,
                                        unsigned Depth = 0) const;
----------------
RKSimon wrote:
> You might be better off keeping the NegatibleCost enum and using it as a threshold value instead.
Good suggestion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77319/new/

https://reviews.llvm.org/D77319