[PATCH] D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 2 17:22:37 PDT 2020
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.h:17
+namespace objdump {
+Optional<XCOFF::StorageMappingClass>
+getXCOFFSymbolCsectSMC(const object::XCOFFObjectFile *Obj,
----------------
hubert.reinterpretcast wrote:
> Please include an interface header that is expected to provide `Optional` as part of its interface.
The comment is not actually addressed. `XCOFFObjectFile.h` does not physically contain any reference to `Optional`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72973/new/
https://reviews.llvm.org/D72973
More information about the llvm-commits
mailing list