[PATCH] D68233: [FPEnv] [WIP] Verify strictfp attribute correctness

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:2888
+  // Verify strictfp attributes match.
+  Function *ContainingF = Call.getFunction();
+  AttributeSet CFnAttrs = ContainingF->getAttributes().getFnAttributes();
----------------
Can check the attribute directly on Call? Also missing tests for this part?


================
Comment at: llvm/test/Verifier/fp-intrinsics.ll:94
+
+; Test for mismatched function and function call attributes
+; CHECK7: Functions and their contained calls must match in use of attribute strictfp!
----------------
Should have a real call for this, not the constrained intrinsic?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68233/new/

https://reviews.llvm.org/D68233