[PATCH] D77308: [DWARF] Detect extraction errors in DWARFFormValue::extractValue
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 2 16:17:51 PDT 2020
dblaikie added a comment.
This change adds a bunch more error handling, if I understand correctly (previously extractValue would've silently succeeded (it could only return true) where now it will fail) - I'd expect some negative test cases demonstrating the new failure modes/error cases being handled? Is there a reason they're not tested?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77308/new/
https://reviews.llvm.org/D77308
More information about the llvm-commits
mailing list