[PATCH] D49116: Setup clang-format as an Arcanist linter

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: utils/arcanist/clang-format.sh:43
+  arc_base_commit=$(arc which --show-base)
+  # An alternative is to use git-clang-format.
+  git diff -U0 --no-color "${arc_base_commit}"| clang-format-diff -style LLVM -i -p1
----------------
Can we just use  `git clang-format` indeed?


================
Comment at: utils/arcanist/clang-format.sh:46
+else
+  svn diff --diff-cmd=diff -x -U0 "${src_file}" | clang-format-diff -style LLVM -i
+fi
----------------
This does not seem relevant now that we're on GitHub.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49116/new/

https://reviews.llvm.org/D49116