[PATCH] D77167: [GraphDiff] Extend GraphDiff to track a list of updates.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 15:11:56 PDT 2020


dblaikie added inline comments.


================
Comment at: llvm/include/llvm/IR/CFGDiff.h:139
+    auto U = LegalizedUpdates.pop_back_val();
+    UpdateMapType *SuccMap, *PredMap;
+    unsigned IsInsert =
----------------
These two variables are uninitialized & used later, guess the uses should be changed to Edges[IsInsert], etc... 

(or since they're used in a few places, you could: const auto &E = Edges[IsInsert]; .... E.Pred(..), E.Succ(...))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77167/new/

https://reviews.llvm.org/D77167





More information about the llvm-commits mailing list