[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

Jonathan Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 14:06:39 PDT 2020


jroelofs added a comment.

In D77227#1957790 <https://reviews.llvm.org/D77227#1957790>, @jdenny wrote:

> In D77227#1957707 <https://reviews.llvm.org/D77227#1957707>, @jroelofs wrote:
>
> > The diagnostic in this patch triggers 186 times in the suite of 36125 tests in llvm/test. Most of them are true positives, though there are ~45 false-positives that seem easy to work around by rewording the comments:
>
>
> So 1/4 of positives are false positives?  Am I reading those numbers correctly?


Yes, that's correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227





More information about the llvm-commits mailing list