[PATCH] D67646: [llvm][TextAPI] adding inlining reexported libraries support

Thu Apr 2 12:28:38 PDT 2020

cishida marked 4 inline comments as done.
cishida added a comment.

the lint corrections will be/have been made in the revision that lands.

================
Comment at: llvm/unittests/TextAPI/TextStubV4Tests.cpp:477
+  raw_svector_ostream OS(Buffer);
+  auto Result = TextAPIWriter::writeToStream(OS, File);
+  EXPECT_FALSE(Result);
----------------
jhenderson wrote:
> There's a lot of usage of `auto` in this and the other files, and I'm pretty sure this is stretching LLVM's coding standard on the topic - the type isn't obvious. See https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable.
got it! I will update these files to update these usages in a separate patch to conform to the standard. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67646/new/

https://reviews.llvm.org/D67646